Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogic 1.x: Random choices are ALL logged in history system #1710

Closed
zaknafean opened this issue Sep 3, 2023 · 2 comments
Closed

Dialogic 1.x: Random choices are ALL logged in history system #1710

zaknafean opened this issue Sep 3, 2023 · 2 comments
Labels
Bug 🐞 Something isn't working

Comments

@zaknafean
Copy link
Collaborator

The problem

Describe the bug
Take a timeline like so:
image

It runs fine, picks a random choice
image

But check the history and every choice is logged. Gotta fix that.
image

Solutions

No solutions or workaround yet. Easy fix is gonna be just make it do the random again, but it would be better if it was consistent.

Any idea to fix the issue or a link to the line of code that might be the cause for this problem

@Jowan-Spooner Jowan-Spooner added this to the Version 1.x milestone Sep 7, 2023
@Jowan-Spooner
Copy link
Member

I solved this in 2.x by having the "text subsystem" (I know that doesn't exist in 1.x but I think you have a text parser script?) send the finished text to the history system instead of logging it from the event. That's how the whole history works actually: events or subsystems can send "history-info" to the history.

Not sure if this is at all helpful, just wanted to write it down as we had to deal with the same problem (#1352).

@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Sep 7, 2023
@coppolaemilio coppolaemilio removed this from the Version 1.x milestone Jan 6, 2024
zaknafean added a commit that referenced this issue Jan 28, 2024
Fixed history text parsing
@zaknafean
Copy link
Collaborator Author

Fixed, but I accidently didn't make a branch for it, still it is now working on the 1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Development

No branches or pull requests

3 participants