-
Notifications
You must be signed in to change notification settings - Fork 466
eclipse formatter break with multiline string #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting! Right now, the default version of the eclipse formatter is spotless/lib-extra/src/main/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStep.java Line 35 in f71d911
And that's the latest version we currently support: So we're missing |
Provide the missing Eclipse support with #678 . |
Niiiice, I'm eager to have once again an auto-formatter |
Released in |
That weird. I've updated my dependency, but I still have the same error message. Is there something i should be aware of ? |
@benzen could you do me a favour and try the following config? eclipse('4.16.0').configFile("$rootProject.projectDir/config/spotless/formatter.xml") |
Thansk for the extra quick answer. Still have the same issue. |
Do you want me to provide my config file ? |
In fact the error i'm seeing now is a little bit different
|
here is my config
|
@benzen In your previous comment you wrote that the output states:
I thought we are talking about the Eclipse formatter. That was part of the initial output you provided:
I have somehow the feeling that we are talking now about a different problem. |
Maybe this is due to the fact that i'm using google style format ? |
In your previous comment you stated that your configuration looks like this:
Since you report a problem in the So if this new error is about the Google-Java formatter step, this should be addressed in a new issue.
|
For modern java features, you probably want gjf 1.8 or 1.9. They are not our default because they require Java 11+ to run, and our min req is still 8. |
In fact using eclipse formatter as describe earlier, or googleJavaFormatter as described in the gradle plugin doc. As pointedout by @fvgh it's probably somthing else. But it's unclear to me where i did somehing wrong |
Turns out it's a problem with another step. I'll open another issue for this one |
gradlew spotless[Apply/Check] --stacktrace
If you're just submitting a feature request or question, no need for the above.
I'm using gradle plugin version 5.2.0 with java 14 on macos 10.15.6
When i use multiline string eclipse prettier break the build.
If you are submitting a bug, please include the following:
Here is my config
Here is my stacktrace
The text was updated successfully, but these errors were encountered: