Skip to content

Docs: additional info about Eclipse formatter (Maven Plugin) #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

Emkas
Copy link
Contributor

@Emkas Emkas commented Jan 11, 2023

3 changes if Maven Plugin docs:

  • Docs: additional info about Eclipse formatter version (0d6e8ea)
  • Docs: update version of Eclipse formatter (4.13.0 -> 4.21.0) (e9c840f)
  • Docs: fixed broken link to Eclipse WTP compatible versions (a43274a)

Maybe I'm a moron, but for me it's not clear that version is not about Eclipse version but rather formatter version. For some time if looks like this was the same, but now Eclipse has stable 4.25, but formatter is 4.22 and the latest supported version by Spotless is 4.21 (for now).

If you want I can break this PR in two. Since fixing a broken link is rather straight forward.

@nedtwigg nedtwigg merged commit 219d6a8 into diffplug:main Jan 11, 2023
@Emkas Emkas deleted the docs-eclipse-formatter branch January 11, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants