Skip to content

Provide Gradle projects as dependencies #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Nov 23, 2023

I just finished the support for Gradle projects, need more work to support Gradle's version catalogs, type-safe project accessors, or something else. May need to review this carefully, it would be better to merge this after 6.23.0 is out.

Closes #1901.

Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JarState is part of the public API, I don't want to break its API unless we have to. And even if we have to, I don't want to rename its methods and reorder its parameters.

It would also be easier to review if there were fewer name / arg changes.

@Goooler Goooler marked this pull request as draft December 4, 2023 01:32
@Goooler
Copy link
Member Author

Goooler commented Dec 16, 2023

I'm closing this for now, we can probably finish this by reusing spotless configuration.

@Goooler Goooler closed this Dec 16, 2023
@Goooler Goooler deleted the support-gradle-projects-as-deps branch December 16, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using Gradle projects as the dependency inputs
2 participants