Skip to content

fix: 🐛 Update variable declaration in Window example #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2018

Conversation

lievenvg
Copy link
Contributor

Issues: 99

PR Checklist

This PR fulfills the following requirements:

  • The commit message follows our guidelines: Contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A changelog entry was added

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #99

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Resolved issues

@lievenvg
Copy link
Contributor Author

Blijkbaar was de oorspronkelijke implementatie 'a mixed bag'.
Nu is de implementatie en documentatie correct zodat het ook icm AOT werkt.

Copy link
Contributor

@TriangleJuice TriangleJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect zo! Kunnen we a.u.b. wel teruggaan naar de afgesproken commit format?

@lievenvg
Copy link
Contributor Author

My bad, was automatisme van een ander project waarin Commitizen wordt gebruikt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants