Feature/examples search filter #74
Conversation
|
|
||
| export class AppModule {};`; | ||
|
|
||
| public searchfilterExampleJS1 = `public stuff: SearchFilterChoice[] = [{ |
There was a problem hiding this comment.
You can add import { SearchFilterChoice } from '@acpaas-ui/ngx-components/forms'; here.
| ## Usage | ||
|
|
||
| ```typescript | ||
| import { SearchFilterModule } from '@acpaas-ui/ngx-components/search-filter'`; |
| | ----------- | ------ | -------------------------- | | ||
| | `@Input() id: string;` | - | Field id. | | ||
| | `@Input() name: string;` | - | Field name. | | ||
| | `@Input() flyoutSize: enum;` | `FlyoutSize.Small` | Passed along to `auiFlyout`. | |
There was a problem hiding this comment.
Perhaps describe it a bit more. It's straight forward, but you can copy some content from the flyout.
There was a problem hiding this comment.
Suggestion: maybe it's better to provide link to the appropriate documentation?
| | `@Input() id: string;` | - | Field id. | | ||
| | `@Input() name: string;` | - | Field name. | | ||
| | `@Input() flyoutSize: enum;` | `FlyoutSize.Small` | Passed along to `auiFlyout`. | | ||
| | `@Input() flyoutAlign: string;` | `'left'` | Passed along to `auiFlyout`. | |
| @@ -0,0 +1,83 @@ | |||
| # @acpaas-ui/ngx-components/forms | |||
|
|
|||
| The search-filter is a JIRA-like filter component with remote search capabilities. | |||
There was a problem hiding this comment.
search filter (without hyphen).
| | ----------- | ------ | -------------------------- | | ||
| | `@Input() id: string;` | - | Field id. | | ||
| | `@Input() name: string;` | - | Field name. | | ||
| | `@Input() flyoutSize: enum;` | `FlyoutSize.Small` | Passed along to `auiFlyout`. | |
There was a problem hiding this comment.
Suggestion: maybe it's better to provide link to the appropriate documentation?
| | `@Input() id: string;` | - | Field id. | | ||
| | `@Input() name: string;` | - | Field name. | | ||
| | `@Input() flyoutSize: enum;` | `FlyoutSize.Small` | Passed along to `auiFlyout`. | | ||
| | `@Input() flyoutAlign: string;` | `'left'` | Passed along to `auiFlyout`. | |
| | `@Input() choices: SearchFilterChoice[];` | - | Available choices. | | ||
| | `@Input() remote: boolean;` | `false` | Enable remote searching. | | ||
| | `@Input() placeholder: string;` | `'Zoeken'` | Search field placeholder text. | | ||
| | `@Input() inputDelay: string;` | `'150'` | Delay the search callback on the input field. | |
There was a problem hiding this comment.
Is this really a string? Then we should list it in our technical debt document.
There was a problem hiding this comment.
no number when verifying in the new components. Older readme had a wrong type defined.
| @@ -1,4 +1,5 @@ | |||
| import { NotificationsState } from './store.types'; | |||
| import { NOTIFICATIONS_INITIAL_VALUE } from './notifications/notifications.initial-state'; | |||
There was a problem hiding this comment.
Please be careful when using git stash!
There was a problem hiding this comment.
Deze zit er nog steeds in?!
There was a problem hiding this comment.
ik kan de NOTIFICATIONS_INITIAL_VALUE toch niet weg doen, want dan is er een error dat deze niet kan gevonden worden. wat is uw voorstel?
# Conflicts: # package-lock.json
# Conflicts: # CHANGELOG.md # packages/forms/examples/forms/forms.module.ts
styleguide/styles.scss
Outdated
| padding: 0 $spacer; | ||
| } | ||
| } | ||
| a-button--navigation |
| @@ -1,4 +1,5 @@ | |||
| import { NotificationsState } from './store.types'; | |||
| import { NOTIFICATIONS_INITIAL_VALUE } from './notifications/notifications.initial-state'; | |||
There was a problem hiding this comment.
Deze zit er nog steeds in?!
styleguide/styles.scss
Outdated
| @@ -47,40 +47,6 @@ main { | |||
| } | |||
| } | |||
|
|
|||
| .o-header__link { | |||
There was a problem hiding this comment.
Waarom wordt dit allemaal verwijderd?
# Conflicts: # package-lock.json # packages/forms/src/lib/mask/README.md # packages/forms/src/lib/range-slider/README.md # packages/forms/src/lib/timepicker/README.md # packages/forms/src/lib/wysiwyg/README.md
|
Er zit nog een bug in de search filter component zelf: als er geen resultaten zijn, dan wordt er een paragraaf getoond met een verkeerde class ( |
# Conflicts: # package-lock.json # styleguide/index.html
PR Checklist
This PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Resolved issues