Skip to content

Document Member nick being optional #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

BartArys
Copy link
Contributor

@BartArys BartArys commented Nov 5, 2020

This PR changes the nick field from being nullable to being nullable and optional.

The documentation currently indicates that nick in guild members is nullable but not optional, yet this field does not appear when receiving members without nicknames through the Gateway (e.g. GUILD_CREATE).

Copy link
Contributor

@webtax-gh webtax-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although minor, this PR is accurate and improves the docs. lgtm

@SGrondin SGrondin mentioned this pull request Dec 15, 2020
vladfrangu added a commit to discordjs/discord-api-types that referenced this pull request Dec 27, 2020
@typpo typpo merged commit d400d0b into discord:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants