Skip to content

types(Collection): union types on intersect and difference #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

intersect and difference can now accept collections with different value types.

Status and versioning classification:
Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni suneettipirneni force-pushed the types/collection/value-merging branch from cc51676 to 1266dd7 Compare January 7, 2022 20:12
@iCrawl iCrawl added this to the collection v1 milestone Jan 7, 2022
@iCrawl iCrawl merged commit 1f9b922 into discordjs:main Jan 7, 2022
@suneettipirneni suneettipirneni deleted the types/collection/value-merging branch February 7, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants