Tarball migration utility #3563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
Contrib
Operations
webbnh
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looks generally excellent -- I didn't find anything I would hold the merge for (although I do have a couple of concerns), but I have a bunch of thoughts to share.
My concerns are the unguarded use of split("::") (which looks like it could cause an error) and the writing of the checkpoint file during preview (which looks like it would allow a user to screw himself a little too easily).
PBENCH-1279 A utility to bulk-migrate Pbench results tarballs to a Pbench Server using the `PUT` API. This supports checkpointing to more efficiently retry after a failure, and filtering by file system modification date.
webbnh
previously approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1279
A utility to bulk-migrate Pbench results tarballs to a Pbench Server using the
PUTAPI. This supports checkpointing to more efficiently retry after a failure, and filtering by file system modification date.