Stop inlining images in CSS #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are done on top of including the raw assets, doubles the work. There's no need for this optimization since DDT is for debug mode only, and with a restrictive Content Security Policy, the `data:` URL's trigger an unnecessary error before the real asset gets loaded. These were last touched in django-commons#1097 / b356100.
jdufresne
approved these changes
Nov 27, 2018
|
Thanks! |
|
Can we get a release? I'd like to use this and #1108. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are done on top of including the raw assets, doubles the work. There's no need for this optimization since DDT is for debug mode only, and with a restrictive Content Security Policy, the
data:URL's trigger an unnecessary error before the real asset gets loaded.These were last touched in #1097 / b356100.