Keep pannel close button accessible with external styles #2128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
External styles such as missing.css can interfere with the display of the panel header elements, and since these are currently rendered after the button they can appear ontop and block click events from passing through. Fix was fairly straightforward, have just swapped the order of display everwhere I could find these pairs of elements.
Fixes #2083
While the selenium tests are all working, I haven't quite figured out how I could incorporate a regression test for this. I've narrowed the offending css down to this rule:
And I've tested manually that this will break the close button before this PR and not after, but I can't quite see how to approach setting up a test case for this. The test cases I've edited do at least assert that the content of the button is rendered after the headers, so it is indirectly tested for, perhaps that is suffient?
Checklist:
docs/changes.rst
.