Fixed #28127 -- Allowed UserCreationForm's password validation to check all user fields. #8408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
reviewed
Jun 14, 2017
django/contrib/auth/forms.py
Outdated
| try: | ||
| password_validation.validate_password(password, self.instance) | ||
| except forms.ValidationError as error: | ||
| self.add_error("password2", error) |
django/contrib/auth/forms.py
Outdated
| return password2 | ||
|
|
||
| def _post_clean(self): | ||
| super()._post_clean() # creates self.instance |
There was a problem hiding this comment.
For the comment, I'd say # updates self.instance with form data (since self.instance is first assigned in ModelForm.init()` "creates" might be confusing)
django/contrib/auth/forms.py
Outdated
| return password2 | ||
|
|
||
| def _post_clean(self): | ||
| super()._post_clean() # creates self.instance | ||
| password = self.cleaned_data.get("password2") |
docs/releases/2.0.txt
Outdated
| @@ -54,6 +54,10 @@ Minor features | |||
| * The default iteration count for the PBKDF2 password hasher is increased from | |||
| 36,000 to 100,000. | |||
|
|
|||
| * The :class:`~django.contrib.auth.forms.UserCreationForm` and subclasses will | |||
There was a problem hiding this comment.
I would consider this a bug fix rather than a minor feature so no release note is needed.
tests/auth_tests/test_forms.py
Outdated
| @@ -872,3 +872,118 @@ def test_password_whitespace_not_stripped(self): | |||
| self.assertTrue(form.is_valid()) | |||
| self.assertEqual(form.cleaned_data['password1'], data['password1']) | |||
| self.assertEqual(form.cleaned_data['password2'], data['password2']) | |||
|
|
|||
|
|
|||
| @override_settings(AUTH_PASSWORD_VALIDATORS=[ | |||
There was a problem hiding this comment.
I think it's enough to include a single test in UserCreationFormTest. Testing for both first_name and last_name seem unnecessary.
Adding tests for PasswordChangeForm that aren't affected by this change shouldn't be done in this commit.
timgraham
changed the title
|
Hi Tim, Changes made! I think this is good to go. Please let me know if I misunderstood any of your instructions. |
…ck all user fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking all fields in the form, not just the username