Skip to content

IllegalArgumentException when getting Javadoc for nested class that has no Javadoc #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dnault opened this issue Jul 23, 2022 · 1 comment
Closed

IllegalArgumentException when getting Javadoc for nested class that has no Javadoc #69

dnault opened this issue Jul 23, 2022 · 1 comment
Assignees
@dnault
Labels
bug
Milestone
0.15.0

Comments

@dnault
Copy link
Owner

dnault commented Jul 23, 2022

Affected version: 0.14.0

Class `javasource.foo.DocumentedClass.NestedWithoutJavadoc` does not match class doc for `javasource.foo.DocumentedClass$NestedWithoutJavadoc`
java.lang.IllegalArgumentException: Class `javasource.foo.DocumentedClass.NestedWithoutJavadoc` does not match class doc for `javasource.foo.DocumentedClass$NestedWithoutJavadoc`
	at com.github.therapi.runtimejavadoc.ClassJavadoc.createEnhancedClassJavadoc(ClassJavadoc.java:102)
	at com.github.therapi.runtimejavadoc.RuntimeJavadoc.getJavadoc(RuntimeJavadoc.java:55)
        ...
@dnault dnault added the bug label Jul 23, 2022
@dnault dnault added this to the 0.15.0 milestone Jul 23, 2022
@dnault dnault self-assigned this Jul 23, 2022
dnault added a commit that referenced this issue Jul 23, 2022
@dnault
IllegalArgumentException when getting Javadoc for nested class that h…
2a8bc27 
…as no Javadoc #69

A subclass with no Javadoc does not inherit method docs from superclass #70

Loosen the class name check, so it doesn't complain about canonical versus
non-canonical class name. Make it an assertion, so we only pay the cost
when running tests.

When scanning for inherited Javadoc, rework the "isEmpty" check.
Instead of bailing out early if the subclass has no Javadoc,
Wait until after the scan is complete.
@dnault dnault closed this as completed Jul 23, 2022
@dnault
Copy link
Owner Author

dnault commented Jul 23, 2022

Thank you to @yanxiyue who initially reported this in PR #68 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnault dnault

Labels
bug
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
1 participant
@dnault