This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Make usernamespaces work without sidecar process #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the console handling to chown the console on creation to the root user within the container. This also moves the setup mounts from the userns sidecar process into the main init processes by trying to mknod devices, if it fails on an EPERM then bind mount the device from the host into the container for use. This prevents access issues when the sidecar process mknods the device for the usernamespace returning an EPERM when writting to dev/null. This also adds some error handling for init processes and nsinit updates with added flags for testing and other functions. Signed-off-by: Michael Crosby <[email protected]>
|
Great, I got as far as figuring out that we needed to bind mount :) |
| return nil | ||
| } | ||
| // containers running in a user namespace are not allowed to mknod | ||
| // devices so we can just bind mount it from the host. |
There was a problem hiding this comment.
could we pass a host bind flag here instead of relying on EPERM?
|
Good job! Except two tiny comments, LGTM. Thanks. |
crosbymichael
force-pushed
the
userns-updates
branch
from
d5940a4 to
c8a1b2f
Compare
|
@avagin updated |
|
LGTM, thanks |
crosbymichael
force-pushed
the
userns-updates
branch
2 times, most recently
from
d36f2ac to
6d8d41e
Compare
Move the network setup back into the standard init even for user namespaces now that mounts are fully supported and working. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
userns-updates
branch
from
6d8d41e to
afa8443
Compare
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Feb 19, 2015
Make usernamespaces work without sidecar process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VICTORY
After spending alot of time reading long strace's I finally found a way to get user namespaces with work with all of the standard code.
The big changes is trying to mknod a device, if you get an EPERM then bind mount it, done.
ping @mrunalp !!!!!