Skip to content

add healthcheck debian #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add healthcheck debian #28

wants to merge 1 commit into from

Conversation

sgohl
Copy link

@sgohl sgohl commented Sep 26, 2017

add healthcheck debian

add healthcheck
@tianon
Copy link
Member

tianon commented Sep 26, 2017

So, using pidof memcached as a health check isn't going to do what you expect. In this image, memcached runs as PID 1, which means that if it crashes for any reason, the container itself will stop and any/all other processes will be killed.

Additionally, the reasons yosifkit outlined over in docker-library/cassandra#76 (comment) for not adding HEALTHCHECK to official images in general still definitely apply today. ❤️

Thanks!

@tianon tianon closed this Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants