Skip to content

Avoid cache in Alpine apk add #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2016
Merged

Avoid cache in Alpine apk add #228

merged 1 commit into from
May 17, 2016

Conversation

robbertkl
Copy link
Contributor

Adds --no-cache to the final apk add in the Dockerfile. The other apk add's already have this flag; however the cache is currently created anyway because of the final apk add.

@tianon
Copy link
Member

tianon commented May 17, 2016

Oh, nice catch! Would you be willing to update the template, too? (

&& apk add --virtual .php-rundeps $runDeps \
)

@robbertkl
Copy link
Contributor Author

Of course! Sorry, wasn't aware they were generated from a template 😄

Just pushed an amended commit.

@yosifkit
Copy link
Member

Thanks! Builds are green! LGTM

@yosifkit yosifkit merged commit 343b799 into docker-library:master May 17, 2016
tianon added a commit to infosiftr/stackbrew that referenced this pull request May 18, 2016
- `elasticsearch`: 2.3.3 (docker-library/elasticsearch#103)
- `kibana`: 4.5.1 and 4.1.7 (docker-library/kibana#46)
- `mariadb`: allow arbitrary `--user` (MariaDB/mariadb-docker#59)
- `percona`: allow arbitrary `--user` (docker-library/percona#21)
- `php`: fix Alpine cache sticking around (docker-library/php#228)
- `rocket.chat`: 0.31.0
- `ruby`: bundler 1.12.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants