Skip to content

mkdir should work on /run instead of /var/run #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

deinspanjer
Copy link

In debian:jessie, /var/run is a symlink to /run. The docker file creates the postgresql directory under /var/run, but the docker-entrypoint.sh file also tries to make /run/postgresql and chown that as well.

In debian:jessie, /var/run is a symlink to /run.  The docker file creates the postgresql directory under /var/run, but the docker-entrypoint.sh file also tries to make /run/postgresql and chown that as well.
@tianon
Copy link
Member

tianon commented Jun 17, 2016

Since this technically works either way (given that /var/run is a symlink to /run), I think I'd prefer to stick to whichever of the paths PostgreSQL itself is trying to use -- does it use /var/run/postgres (relying on the symlink), or does it use /run directly?

(Also, this change would need to happen in Dockerfile.template and be propagated to all the versions from there. 👍)

@deinspanjer
Copy link
Author

Okay, I ran the container and then exec'ed a bash shell and poked around with lsof. It looks like the generated config is using /var/run for the socket connection and postmaster is using it for the pid, so this should probably stay the way it is for now. :/

@tianon
Copy link
Member

tianon commented Jun 27, 2016

Thanks for doing the additional research! 👍 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants