Skip to content

Switch from OpenSSL to LibreSSL #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Conversation

skwashd
Copy link
Contributor

@skwashd skwashd commented Jun 6, 2017

This was suggested by @JayH5 on PR #201 after it was merged.

@skwashd skwashd mentioned this pull request Jun 6, 2017
@JayH5
Copy link
Contributor

JayH5 commented Jun 6, 2017

That was fast. 😁 Thanks 🍰

I'm not really sure what the LibreSSL vs OpenSSL policy is with Alpine official images. But it seems to me that if LibreSSL is the Alpine default then that is what we should use, especially if other packages are installed that depend on LibreSSL and that then conflicts with OpenSSL.

But I'm sure @tianon will have an answer for us as always :)

@tianon
Copy link
Member

tianon commented Jun 6, 2017

In past conversions (when Alpine 3.5 switched from OpenSSL-by-default to LibreSSL-by-default) we only switched if packages we installed caused conflicts at build-time or run-time, but if this compiles and works, I'm +1 (especially since Alpine 3.5+ does use LibreSSL-by-default, so it makes sense for us to follow suit even/especially to ensure that compatibility works properly and packages can install).

@tianon
Copy link
Member

tianon commented Jun 6, 2017

LGTM, in other words 👍

@tianon tianon merged commit 79ceb74 into docker-library:master Jun 6, 2017
@skwashd skwashd deleted the libressl branch June 6, 2017 14:24
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jun 6, 2017
- `bash`: update git.savannah.gnu.org URLs
- `gcc`: update git.savannah.gnu.org URLs
- `httpd`: update git.savannah.gnu.org URLs
- `memcached`: 1.4.37
- `nextcloud`: add 12.0 (nextcloud/docker#85)
- `postgres`: update git.savannah.gnu.org URLs
- `python`: add Alpine 3.6 variants (docker-library/python#201, docker-library/python#203)
- `rabbitmq`: fix "unbound variable" error (docker-library/rabbitmq#161)
tao12345666333 pushed a commit to tao12345666333/python that referenced this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants