Skip to content

LDAP Support #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonapich opened this issue Oct 18, 2016 · 1 comment
Closed

LDAP Support #116

jonapich opened this issue Oct 18, 2016 · 1 comment

Comments

@jonapich
Copy link

jonapich commented Oct 18, 2016

As mentioned in #76, docker users get painted in the corner when they use environment variables to configure aspects of the configuration file since the rabbitmq.config file will get overriden by the script because of the haveConfig flag.

At the base, the script should probably at least provide a generic and dumb way to inject raw definitions to be appended to the rabbitmq.config file, kinda like what the Chef Cookbook does. This way, everyone will be able to leverage some sort of workaround around the features they need. Unfortunately my sh skills are close to none and I can't possibly contribute this feature in a solid way.

Alternatively, implementing distributed config files (/etc/rabbitmq.config.d/) could solve this problem nicely. Another approach would be to allow for flat-json to be introduced in the environment variables; for instance, providing something like RABBITMQ_CONFIG_RAW.rabbitmq.reverse_dns_lookup=true.

In my particular use-case, I am required to implement the LDAP auth backend. For now, I am thinking of forking and borrow the pattern introduced in #112 to add an LDAP section as well. Is this kind of implementation acceptable for an eventual PR?

@yosifkit
Copy link
Member

Given docker-library/docs#1011, and that 3.7 introduced the new (trivial to write/append to) ini/sysctl-style configuration format (https://www.rabbitmq.com/configure.html#config-file-formats), I'm going to close this.

In Kubernetes, it should be pretty trivial to create a config object which gets inserted at /etc/rabbitmq/rabbitmq.conf with the desired settings included. 👍

(Or to create a derivative image FROM this one which adds a simple ENTRYPOINT that appends the contents of an environment variable to the above-noted file.)

- #186 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants