Skip to content

Add support for heartbeat parameter #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

peterstory
Copy link

The heartbeat parameter should be configurable via an environment variable. I made it configurable with just a couple tweaks to the entrypoint.
https://www.rabbitmq.com/heartbeats.html

@yosifkit
Copy link
Member

Especially with 3.7's simpler config format, we'd rather move to doing less config via the entrypoint. Since it will be simpler for a user to supply their own config file and then the entrypoint can sed their file to update/add a limited set of specific values rather than being responsible for every option possible in a rabbit config.

You should be able to add any config option with RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS as noted in docker-library/docs#1011.

Related open issues asking for extra config options: #44, #76, #79, #85, #110, #116, #118, #164, #185, #186.

@peterstory
Copy link
Author

Ah, very good. Thanks for pointing out RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS.

@tianon
Copy link
Member

tianon commented Oct 18, 2017

👍 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants