Set chmod 600 on existing cookieFile #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the permission of an existing cookie file to the one expected by Erlang. This allows the image to work with Kubernetes StatefulSets, when a new POD takes the place of a existing one that was deleted. Whithout it, an ".erlang.cookie must be accessible by owner only" error will occour, once the Dockerfile sets the entire mount permission to 777.
michaelklishin
approved these changes
Sep 22, 2017
|
So, I don't fully understand what weird thing Kubernetes is doing to cause permissions on this file to reset to 777, but I think this PR could be simpler by just moving the existing Also, this needs to be updated in both copies of this script. 👍 |
|
@tianon thanks for your feedback. I've removed the comment, removed the ducplicated line as you suggested and applied the change in the debian entrypoint as well. 👍 |
|
Looks good, thanks! |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Sep 25, 2017
- `bash`: `scanelf` improvements (tianon/docker-bash#8) - `docker`: update `Dockerfile` with `arm32v6` and `arm64v8` (still blocked on gliderlabs/docker-alpine#304) - `drupal`: `scanelf` improvements (docker-library/drupal#93) - `ghost`: 1.9.0 - `haproxy`: `scanelf` improvements (docker-library/haproxy#45) - `httpd`: `scanelf` improvements (docker-library/httpd#74) - `irssi`: `scanelf` improvements (jessfraz/irssi#18) - `memcached`: `scanelf` improvements (docker-library/memcached#27) - `php`: `scanelf` improvements (docker-library/php#500), `libressl` in Alpine 3.6+/PHP 7.2+ (docker-library/php#499) - `postgres`: `scanelf` improvements (docker-library/postgres#344) - `rabbitmq`: update cookie file permissions (docker-library/rabbitmq#193), consume upstream artifacts from GitHub (docker-library/rabbitmq#195), set `total_memory_available_override_value` (docker-library/rabbitmq#196) - `ruby`: `scanelf` improvements (docker-library/ruby#161) - `tomcat`: `scanelf` improvements (docker-library/tomcat#85) - `wordpress`: `scanelf` improvements (docker-library/wordpress#240)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the permission of an existing cookie file to the one expected by Erlang.
This allows the image to work with Kubernetes StatefulSets, when a new POD takes the place of a existing one that was deleted.
Whithout it, an ".erlang.cookie must be accessible by owner only" error will occour, once the Dockerfile sets the entire mount permission to 777.