Add documentation for redirecting 443 SSL traffic to any container port #17178
Conversation
What does this extra example show? How to forward HTTPS 443 traffic to a container's port 8080. At first glance, this may look like a redundant documentation entry. After all, we just showed SSL termination right above this example. We're cluttering the docs! Let me directly address this: - This literally took me 3 straight days to figure out how to do. I arrived at a custom 120 line CloudFormation yaml file before I realized I could do it this way. - There is not a single mention of the `x-aws-protocol` flag on this entire page. This adds a very helpful use case. - The jump to overriding a network load balancer and learning the `x-aws-protocol` flag, plus learning the correct `x-aws-cloudformation` overlay, plus understanding the difference between all the load balancer sub objects (TargetGroup, Listener, LoadBalancer) and knowing which fields to override is non-trivial. - Many web frameworks actively discourage running your server on port 80. It requires root user (sudo) permissions to bind to port 80. You could even argue the port 80 example above this one is encouraging bad practices (see this Digital Ocean explanation https://www.digitalocean.com/community/tutorials/how-to-use-pm2-to-setup-a-node-js-production-environment-on-an-ubuntu-vps#give-safe-user-permission-to-use-port-80 ) I think forwarding HTTPS traffic to a non-privileged container `443:8080` is a VERY common use case, and well worth the extra example here in the docs.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
|
@ndeloof @thaJeztah @craig-osterhout Is there any feedback on what it would take to get this merged in? I'm happy to keep rebasing because we're currently using this SSL termination method in production (it's VERY helpful). |
|
@joshuakcockrell ECS integration is deprecated, I don't expect we make any further improvement to the documentation |
|
Sounds good thanks for letting me know! |
This is a reopening of a 1 year old pull request: #14739 It was assigned to a maintainer but never got reviewed. I am reopening it because I think forwarding HTTPS traffic to a non-privileged container 443:8080 is a VERY common use case, and well worth the extra example here in the docs.
If you're questioning whether or not this is valuable, Here's a ~5000 word blog post someone wrote trying to accomplish the same thing in a VERY hacky way
Original PR
What does this extra example show? How to forward HTTPS 443 traffic to a container's port 8080.
At first glance, this may look like a redundant documentation entry. After all, we just showed SSL termination right above this example. We're cluttering the docs! Let me directly address this:
x-aws-protocolflag on this entire page. This adds a very helpful use case.x-aws-protocolflag, plus learning the correctx-aws-cloudformationoverlay, plus understanding the difference between all the load balancer sub objects (TargetGroup, Listener, LoadBalancer) and knowing which fields to override is non-trivial.Proposed changes
Accept this example into the documentation.
Related issues (optional)
#14739