Skip to content

build: incorporate build guide into manuals #20715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Aug 27, 2024

The build guide that I once wrote now duplicates a lot of content with
the concept guide launched a few months back. It doesn't make sense to
cover the same topics multiple times, so I'm removing the older build
guide and incorporating some of the topics into the build manual
instead.

Signed-off-by: David Karlsson [email protected]

New/revised content:

@dvdksn dvdksn requested a review from crazy-max as a code owner August 27, 2024 13:20
@dvdksn dvdksn requested a review from a team August 27, 2024 13:20
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit df6367f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66cdd591bee8560008b608de
😎 Deploy Preview https://deploy-preview-20715--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command area/get-started Relates to get started and onboarding docs labels Aug 27, 2024
The build guide that I once wrote now duplicates a lot of content with
the concept guide launched a few months back. It doesn't make sense to
cover the same topics multiple times, so I'm removing the older build
guide and incorporating some of the topics into the build manual
instead.

Signed-off-by: David Karlsson <[email protected]>
@dvdksn dvdksn force-pushed the build-guide-refactor branch from fa5cd87 to df6367f Compare August 27, 2024 13:33
@thompson-shaun
Copy link
Contributor

Love seeing the de-duplication work on this. It helps the user experience a bunch.

Haven't finished by any means but here are a few notes

  • The legacy guide had some "pre-requisite" sections like install and a bit of a "here's your app" which felt like a good way to set the stage for motivation. One might say that if you're reading this doc you're already motivated, but I wanted to make sure we didn't lose anything we wanted in the merge :)

@dvdksn
Copy link
Contributor Author

dvdksn commented Aug 27, 2024

Thanks @thompson-shaun

The legacy guide had some "pre-requisite" sections

Yeah, with this change I am also moving away from the tutorial-style sequence of things, where we expected users to go from A, B, C, etc. Here we're describing each of the capabilities in a more standalone way instead. Which is also why e.g. the Dockerfile examples are most of the time using something like a git context as well, as opposed to assuming that any local files exist. Just so that they can be "stateless".

I did try to make sure that we have the prerequisites for each thing listed out, e.g. containerd for multi-platform, but let me know if something seems off or missing. I will have another look.

@thompson-shaun
Copy link
Contributor

I like the play tbh, it avoids drift between those sections.

Other alternatives that come to mind: If we could link to a single source of truth or offer a nudge to "check your setup". Either way I like the new setup 😄

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@dvdksn dvdksn merged commit 6bce6d7 into docker:main Aug 28, 2024
14 checks passed
@dvdksn dvdksn deleted the build-guide-refactor branch August 28, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command area/get-started Relates to get started and onboarding docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants