Skip to content

Extra package requirements for RHEL #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Extra package requirements for RHEL #4529

merged 1 commit into from
Sep 7, 2017

Conversation

mdlinville
Copy link

Addresses docker/for-linux#20 (comment)

cc/ @friism @alecbenzer

@mdlinville mdlinville requested a review from gbarr01 September 6, 2017 21:35
@friism
Copy link
Contributor

friism commented Sep 6, 2017

lgtm, thx @mstanleyjones

@alecbz
Copy link

alecbz commented Sep 6, 2017

I think the statement on line 76 should also be amended?

https://github.com/docker/docker.github.io/pull/4529/files#diff-d68b03b9222bc72efb04d43ffca30c1bR76

The "Install from package" installation method is no longer "useful in situations such as installing Docker on air-gapped systems with no access to the internet".

@mdlinville
Copy link
Author

Yes it is! If you need to do it that way you need to get the dependency (and any other uninstalled dependencies) some other way. One very typical way for RHEL is to have local mirrors of the important repos. I'm not going to tell RHEL admins how to do their jobs.

Copy link
Contributor

@gbarr01 gbarr01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdlinville mdlinville merged commit 9bc472b into docker:master Sep 7, 2017
@mdlinville mdlinville deleted the rpm-extras branch September 7, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants