Skip to content

feat(dev): add gulp tasks #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2017
Merged

feat(dev): add gulp tasks #12

merged 3 commits into from
Mar 24, 2017

Conversation

jrappen
Copy link
Contributor

@jrappen jrappen commented Mar 24, 2017

See Files changed tab for details.


@QingWei-Li Could you fix the previous commit messages so gulp changelog works as expected? I'm not sure how to do that.

package.json Outdated
"homepage": "https://github.com/QingWei-Li/docsify-cli#readme",
"repository": {
"type": "git",
"url": "git+https://github.com/QingWei-Li/docsify-cli.git"
},
"license": "MIT",
"engines": {
"node": ">= 4"
"node": ">= 6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is compatible with Node 4 and npm 3.

@@ -1,7 +1,13 @@
{
"completion": "Drucke shell Vervollständigungsskript",
"epilog": "Dokumentation",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to remove it? I noticed that it exists in en.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add a translation, still looking for a fix for the problem described by @kamilchm in 02dec13

@QingWei-Li
Copy link
Member

@jrappen
Thank you for the PR. Is it done?

@jrappen
Copy link
Contributor Author

jrappen commented Mar 24, 2017

@QingWei-Li As far as I got, yes.

Maybe you could review the chinese translations and then fix previous commit messages so they'll work with gulp changelog if possible?

@QingWei-Li
Copy link
Member

I see. let me do it.

@QingWei-Li QingWei-Li merged commit 8eea106 into docsifyjs:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants