-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
externalLinkRel not working if externalLinkTarget: '_blank' #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This seems like a bug.
Submit a PR in awesome-docsify |
Done here. Thanks for the heads up. |
This has been removed somehow in this commit 724ac02#diff-d73f215ac772d2673dd8c51f24976e4eL256 Thanks for pointing. It will be fixed soon |
Glad to help. |
fix: fixed target and rel issue (fixes #1183)
Bug Report
Re. #917 / #914, when
externalLinkTarget: '_blank'
andexternalLinkRel: 'noopener'
, href should be:but it's being generated as:
Steps to reproduce
Add an external link to a markdown file:
Add this do
window.$docsify
:What is current behaviour
Links are generated without
rel="noopener"
. Example:What is the expected behaviour
Links should have
rel="noopener"
. Example:Other relevant information
Bug does still occur when all/other plugins are disabled?
Your OS: GNU Linux
Node.js version: none
npm/yarn version: none
Browser version: Chromium 81.0.4044.138
Docsify version: 4.11.3
Docsify plugins: docsify-copy-code, external-script, search, zoom-image, prism-bash, prism-json, prism-markdown, docsify-tabs
Please create a reproducible sandbox
Mention the docsify version in which this bug was not present (if any)
Not tested in other versions.
PS: add to showcase
I've just published a brand new website of my company made entirely with docsify. I would appreciate to have it listed in the showcase. The entry might look like:
The text was updated successfully, but these errors were encountered: