-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
remove bundle size from Docsify home page #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Perhaps focusing on other measures (like Lighthouse scores) would give the maintainers measurable targets and a better sense of overall performance for devs. Surprisingly, the current numbers for docsify.js.org aren't terrible. There's room to improve though, which we should prioritize for v5. FWIW, docsify-themeable fares better. It would be great to get these scores to 100 across the board if possible. (Note: The scores above were taken using the Lighthouse tab found Chrome's Dev Tools. A web version is also available at https://web.dev/measure/ but the "Performance" test encountered failed while auditing docsify-themeable's website.) |
One thought, We can add lighthouse in the CI ref. |
We can pick each Points from the report can fix them. |
In regards to the bundle size are you guys referring to this and make it similar to https://simps.io/#/? I would like to try and integrate lighthouse-ci |
yes, thats the one.
great, feel free to do so, |
Thanks |
Based on some other discussions we've had with @jhildenbiddle, we should perhaps remove the bundle size from the home page, and not worry so much about the size limit and moreso focus on what features make Docsify great.
My opinion: the current file size limit potential and awesome features from being introduced just because we're already at the file size limit.
The text was updated successfully, but these errors were encountered: