Skip to content

Accessibility issues #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PicchiKevin opened this issue Nov 14, 2019 · 3 comments
Closed

Accessibility issues #945

PicchiKevin opened this issue Nov 14, 2019 · 3 comments

Comments

@PicchiKevin
Copy link
Contributor

Hi,

Here are some issues that I found regarding accessibility:

  • Viewport not allowing to scale and zoom
  • The burger menu button must have discernible text
  • The burger menu button must have a :focus styling
  • Search plugin is text missing a label for the search input
  • Search text input is also missing a :focus styling

Low contrast text according to Web Content Accessibility Guidelines (WCAG) 2.1:

  • Between #42b983 and #ffffff (ratio: 2.47)
  • Between #858585 and #ffffff (ratio: 3.69)
  • Between #e96900 and #ffffff (ratio: 3.04)
  • Between #36bc98 and #ffffff (ratio: 2.38)

I also do like to note that some of the image alternate text can be improved.

I can submit a PR for the first 5 issues, but what should we do about the contrast ratio ?

PS: Sorry about not following the templates, but this is not a bug report nor a feature request

@anikethsaha
Copy link
Member

The burger menu button must have discernible text

You meant a tooltip ?

Search text input is also missing a :focus styling

what style are you planning to add in the focus?

Feel free to submit a PR

We can take a look at the ratio thing Future.

@PicchiKevin
Copy link
Contributor Author

PicchiKevin commented Nov 25, 2019

For the burger menu an aria label should do the trick although the button seems a bit small.

And for the text input here is what I was thinking of :
screenshot on the search bar of docsify with an outer glow
(An outer glow should be enough I thing, with the theme color)

@anikethsaha
Copy link
Member

For the burger menu an aria label should do the trick although the button seems a bit small.

Can you try this and share the screenshot

And about the input, try something which will work with other theme too. And I think the outer glow is bit more, try reducing it little bit

anikethsaha added a commit that referenced this issue May 7, 2020
…ility

Improve accessibility of viewport meta by allowing page zoom (related to #945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants