We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When window.$docsify.logo is set, window.$docsify.name does not get escaped properly.
window.$docsify.logo
window.$docsify.name
mkdir test && cd test
docsify init . && docsify serve .
"
It sets it as raw HTML value instead of the alt text.
alt
<!-- 'window.$docsify.name' -> 'hello test"'--> <!-- 'window.$docsify.logo' -> 'https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/1200px-Cat03.jpg"'--> <img alt="hello" test"="" src="https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/1200px-Cat03.jpg">
When no image is provided, it does get escaped properly:
Correctly escaping " to " and others (space, etc) or using escaping it using something else.
"
Bug does still occur when all/other plugins are disabled?
Your OS: Windows 10 1903
Windows 10 1903
Node.js version: 12.13.1
12.13.1
npm/yarn version: 6.13.2
6.13.2
Browser version: 78.0.3904.108
78.0.3904.108
Docsify version: Latest 4.9.4 (//unpkg.com/docsify/lib/docsify.min.js)
Latest 4.9.4 (//unpkg.com/docsify/lib/docsify.min.js)
Docsify plugins: None
None
The text was updated successfully, but these errors were encountered:
Merge pull request #974 from Koooooo-7/develop
1622578
[fix]#972 when 'logo' is set, 'name' is not set correctly inside the 'alt' as same as without 'logo' set.
Successfully merging a pull request may close this issue.
Bug Report
When
window.$docsify.logo
is set,window.$docsify.name
does not get escaped properly.Steps to reproduce
mkdir test && cd test
docsify init . && docsify serve .
window.$docsify.name
to"
andwindow.$docsify.logo
to a random image.What is current behaviour
It sets it as raw HTML value instead of the
alt
text.When no image is provided, it does get escaped properly:

What is the expected behaviour
Correctly escaping
"
to"
and others (space, etc) or using escaping it using something else.Other relevant information
Bug does still occur when all/other plugins are disabled?
Your OS:
Windows 10 1903
Node.js version:
12.13.1
npm/yarn version:
6.13.2
Browser version:
78.0.3904.108
Docsify version:
Latest 4.9.4 (//unpkg.com/docsify/lib/docsify.min.js)
Docsify plugins:
None
The text was updated successfully, but these errors were encountered: