[WIP] convert all files to ES Module format #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/3Ssdy3KfPfdZWPDfDwcGYTGquhng |
…SM+Playwright separately, as I cannot currently run them locally)
ESLint doesn't support ESM config files yet.
I tried to stay on prettier v1, but it doesn't work in a package with type:module (ESM) because ESLint for some reason would then complain about almost 4000 errors which would require a *ton* of format changes to fix. As a result I had to update to Prettier v2 for it to work properly, and this required only a few format updates to the codebase.
|
Closing, making a new PR. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(WIP) convert all files to ESM.
What kind of change does this PR introduce?
Refactor
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
Tested in the following browsers: