-
Notifications
You must be signed in to change notification settings - Fork 231
PHP8 support #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8 support #665
Conversation
Not sure how to fix coding standards checkout issue |
#662 and this issue are duplicates. |
"php": "^7.2", | ||
"doctrine/annotations": "^1.2", | ||
"doctrine/mongodb-odm": "^2.0.0", | ||
"php": "^7.2 || ^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to use >=7.2
instead to keep it in line with Symfony's preferred versioning strategy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's a terrible strategy
composer.json
Outdated
"doctrine/mongodb-odm": "^2.0.0", | ||
"php": "^7.2 || ^8.0", | ||
"doctrine/annotations": "^1.6", | ||
"doctrine/mongodb-odm": "^2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? The old ^2.0.0
would still allow 2.2 for PHP 8, but right now someone with PHP 7.2 would no longer be able to use doctrine/mongodb-odm 2.0/2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the ^2.0.0
constraint should stay (unless there are some blockers but I don't think there'll be any)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you guys for feedback reverted back to 2.0.0
Should I update code to minimum php 7.3, because php 7.2 is end of live? (https://www.php.net/supported-versions.php) |
I don't think updating the minimum PHP version should be part of this PR. Since Symfony 5 supports PHP 7.2 it makes sense to keep it unless there is something to be gained from dropping it. |
The best for the bundle is to allow same PHP versions as ODM does: let's keep 7.2 for now. If we are going to drop it we will need to release another ODM version first. |
No description provided.