Merge release 4.3.0 into 4.4.x #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This fixes the tag service name and removes reference to some nonexistent options.
Update load fixtures command description
Make commands lazily loaded
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
Migrate cs job to Github Actions
1.3 was released in 2017 and this allows to clean up some tests.
Static analysis would complain to not been able to find those classes. This creates some classes used in tests.
This method has a return type declaration (void) in PHPUnit 8
The annotations expectedException and expectedExceptionMessage has been replace with the corresponding expecting exceptions, ref: sebastianbergmann/phpunit#3332 Also a call to TestCase::assertInternalType has been replaced with TestCase::assertIsInt.
TestCase::assertContains is failing when using PHPUnit 9 because I guess that the Reference instances were not the same, so I copied an assertion from doctrine/doctrine-bundle to check the method call in the definition.
Bump to PHPUnit 8.5 and tests clean up
It is considered risky not to perform assertions.
This test loads a class that uses deprecated phpdoc syntax, but that's intended: we want to work that the type is still guessed properly for those too.
It has been updated according to https://github.com/doctrine/.github/blob/2c60b2f943cf08df21be3dc733f1b92db8d24beb/workflow-templates/coding-standards.yml and also the composer minimum stability has been changed for this job in order to install only stable versions.
Update coding standards to 8.2
Sync continuous-integration job with upstream
Add support for PHP 8
Address master rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 4.3.0
Feature release (minor)
4.3.0
Enhancement
Task
659: Address master rename thanks to @greg0ire
654: Migrate cs job to Github Actions thanks to @franmomu
653: Bump to PHPUnit 8.5 and tests clean up thanks to @franmomu
651: Move website config to default branch thanks to @SenseException