Skip to content

Update to prettier 0.23.0 when it's released #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmcw opened this issue Apr 10, 2017 · 4 comments
Closed

Update to prettier 0.23.0 when it's released #709

tmcw opened this issue Apr 10, 2017 · 4 comments
Labels
upstream

Comments

@tmcw
Copy link
Member

tmcw commented Apr 10, 2017

I've been standardizing on prettier on all projects. I should use it here.
@tmcw
Copy link
Member Author

tmcw commented Apr 10, 2017

This is unfortunately taking longer than expected - estimate was ~20 minutes, looking like ~1hr. Ran into this bug around types as well as a tricky gotcha with the syntax.input.js test fixture, which is invalid JavaScript and should be ignored by prettier.

@tmcw
Copy link
Member Author

tmcw commented Apr 10, 2017

Also ran into this bug around double comments

@tmcw
Copy link
Member Author

tmcw commented Apr 10, 2017

Going to keep this issue open - prettier 0.23.0 will fix both bugs, and I will remove the workaround in server.js when I upgrade.

tmcw added a commit that referenced this issue Apr 10, 2017
@tmcw
style(prettier): Use prettier for code formatting
16caeef 
This saves us style issues. Also adds husky and lint-staged for pre-commit testing

Refs #709
@tmcw tmcw mentioned this issue Apr 10, 2017
Merged
tmcw added a commit that referenced this issue Apr 10, 2017
@tmcw
style(prettier): Use prettier for code formatting
7fdeb6a 
This saves us style issues. Also adds husky and lint-staged for pre-commit testing

Refs #709
tmcw added a commit that referenced this issue Apr 10, 2017
@tmcw
style(prettier): Use prettier for code formatting
fa275be 
This saves us style issues. Also adds husky and lint-staged for pre-commit testing

Refs #709
tmcw added a commit that referenced this issue Apr 10, 2017
@tmcw
style(prettier): Use prettier for code formatting
678006c 
This saves us style issues. Also adds husky and lint-staged for pre-commit testing

Refs #709
tmcw added a commit that referenced this issue Apr 10, 2017
@tmcw
style(prettier): Use prettier for code formatting (#710)
25152ed 
* style(prettier): Use prettier for code formatting

This saves us style issues. Also adds husky and lint-staged for pre-commit testing

Refs #709
@tmcw tmcw changed the title Use prettier Update to prettier 0.23.0 when it's released Apr 10, 2017
@tmcw tmcw added upstream and removed enhancement labels Apr 10, 2017
tmcw added a commit to documentationjs/gulp-documentation that referenced this issue Apr 10, 2017
@tmcw
style(prettier): Use prettier for code formatting
041130c 
Also fixes the position of the GreenKeeper badge in the README

Refs documentationjs/documentation#709 the main issue for documentation
@tmcw
Copy link
Member Author

tmcw commented Apr 13, 2017

prettier 1.0.0 is released! Switching to it.

tmcw added a commit that referenced this issue Apr 13, 2017
@tmcw
style(prettier): Upgrade to prettier 1.0.0
421c333 
Fixes #709
@tmcw tmcw modified the milestone: beta20 Apr 13, 2017
@tmcw tmcw mentioned this issue Apr 14, 2017
Closed
@tmcw tmcw mentioned this issue May 1, 2017
Merged
tmcw added a commit that referenced this issue May 2, 2017
@tmcw
build: Use Flow syntax without comments.
dd7b94a 
We're switching to Flow annotations - not Flow comments. This
gives documentation.js the ability to self-document without
JSDoc types and improves our compatibility with tools like
prettier.

Fixes #729. Fixes #709
tmcw added a commit that referenced this issue May 9, 2017
@tmcw
build: Use Flow syntax without comments.
6adabd5 
We're switching to Flow annotations - not Flow comments. This
gives documentation.js the ability to self-document without
JSDoc types and improves our compatibility with tools like
prettier.

Fixes #729. Fixes #709
@tmcw tmcw closed this as completed in #767 May 9, 2017
tmcw added a commit that referenced this issue May 9, 2017
@tmcw
Native Flow, use Jest (#767)
11d9045 
* build: Use Flow syntax without comments.

We're switching to Flow annotations - not Flow comments. This
gives documentation.js the ability to self-document without
JSDoc types and improves our compatibility with tools like
prettier.

Fixes #729. Fixes #709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmcw