fix: lends with object property using literal key #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciej-ka
commented
Mar 3, 2018
__tests__/fixture/lends.input.js
Outdated
| @@ -6,6 +6,8 @@ | |||
| export default TheClass( | |||
| /** @lends TheClass.prototype */ | |||
| { | |||
| /** My field */ | |||
| myField: true, | |||
There was a problem hiding this comment.
prettier or something similar is changing this line from "myField" into myField, ... looking for proper ignore annotation
maciej-ka
force-pushed
the
fix-lends-with-literal-property-key
branch
from
17bdbbf to
9fb7450
Compare
maciej-ka
commented
Mar 3, 2018
__tests__/fixture/lends.input.js
Outdated
| @@ -6,6 +6,9 @@ | |||
| export default TheClass( | |||
| /** @lends TheClass.prototype */ | |||
| { | |||
| /** My field */ | |||
| // prettier-ignore | |||
There was a problem hiding this comment.
without prettier-ignore "myField" will be changed into myField
There was a problem hiding this comment.
how about naming the field "my field"? Prettier only unquotes properties that are valid identifiers.
tmcw
requested changes
Mar 4, 2018
__tests__/fixture/lends.input.js
Outdated
| @@ -6,6 +6,9 @@ | |||
| export default TheClass( | |||
| /** @lends TheClass.prototype */ | |||
| { | |||
| /** My field */ | |||
| // prettier-ignore | |||
There was a problem hiding this comment.
how about naming the field "my field"? Prettier only unquotes properties that are valid identifiers.
maciej-ka
force-pushed
the
fix-lends-with-literal-property-key
branch
from
9fb7450 to
a3b3248
Compare
tmcw
approved these changes
Mar 4, 2018
|
Thanks! 🎉 |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
This MR closes #840
At the moment if object property key is a literal it will not be processed correctly because conditions check for
NodePath.isIdentifier().