Skip to content

Start --watch integration #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Start --watch integration #236

merged 1 commit into from
Nov 24, 2015

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Nov 9, 2015

Questions:

  • Is chokidar a bad dependency to have? Being a binary install, does it matter? Right now I'm depending on mdast also requiring chokidar such that "we'll have it anyway"

TODO

Fixes #215

@tmcw tmcw force-pushed the watch branch 10 times, most recently from 43f5325 to afc28fb Compare November 20, 2015 18:38
@tmcw
Copy link
Member Author

tmcw commented Nov 20, 2015

Okay, this is ready for a review, cc @jfirebaugh or @mourner: this pulls the functionality of dev-documentation into core: new -w and -s flags respectively watch source files for updates and serve them over http locally.

@jfirebaugh
Copy link
Member

Can we jump ahead a few CLI revisions and do the usual command pattern that everyone seems to settle on:

documentation build
documentation serve [--watch]
documentation lint

@tmcw
Copy link
Member Author

tmcw commented Nov 20, 2015

Would omitting a command show help, or default to build?

@tmcw
Copy link
Member Author

tmcw commented Nov 20, 2015

Also, so far I am permitting for the possibility of --watch working for both building & serving - so, for instance, you could auto-rebuild a Markdown doc too.

@jfirebaugh
Copy link
Member

Show help is what jekyll does, sounds good to me.

👍 on documentation build --watch too.

@tmcw tmcw force-pushed the watch branch 5 times, most recently from 17d18f4 to 6e919ef Compare November 22, 2015 21:50
@tmcw
Copy link
Member Author

tmcw commented Nov 22, 2015

Back to you for review @jfirebaugh, branch now passes tests and needs a line or two of coverage improvement.

@jfirebaugh
Copy link
Member

I don't have time to do a detailed review here. If you're happy, 🚢.

These new flags replace the functionality of
dev-documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants