Membership inference improvements

[chkt]

Added normalization of @memberof Foo# and @memberof Foo.prototype
Added membership inference for this.foo inside constructor functions and class members

[tmcw]

could these index-based checks be expressed more simply with regular expressions? I believe this one would be memberof.match(/\.prototype$/)

[chkt]

I don't know how important performance is to you. It surely would result in more compact code. But the next line would read comment.memberof = memberof.slice(0, -10); which looks a little bit to much on the magical side for my taste.

I could also use a capturing regexp: memberof.match(/^(.*).prototype$/) and use match[1] like this:

var match = memberof.match(/^(.*).prototype$/);

if (match !== null) {
  comment.memberof = match[1];

I'm not sure if that's an improvement in the end. But if this works for you:

  if (memberof.match(/.prototype$/) !== null) {
    comment.memberof = memberof.slice(0, -10);
    comment.scope = 'instance';

    return comment;
  }

I am totally on board.

[tmcw]

Probably the most compact way to express this would be:

  var isPrototype = /.prototype$/;
  if (memberof.match(isPrototype)) {
    comment.memberof = memberof.replace(isPrototype, '');
    comment.scope = 'instance';
    return comment;
  }

Performance certainly matters, but with tiny strings in this place I don't think even a wasteful implementation could take more than 1% of total time.

[chkt]

done

[tmcw]

and this check would be memberof.match(/#$/)

[chkt]

and this is also done.

[tmcw]

👍 Thanks Christoph!

[chkt]