Skip to content

Teacher docs #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Sep 5, 2020
Merged

Teacher docs #73

merged 63 commits into from
Sep 5, 2020

Conversation

winniederidder
Copy link
Contributor

@winniederidder winniederidder commented Aug 12, 2020

English and Dutch version
Tasks:

  • split into multiple pages
    • Course management (cursus aanmaken, de toegang en registratie uitleggen, cursus kopiëren uitleggen)
    • Exercise & series management (reeks aanmaken, oefeningen toevoegen, zichtbaarheid en toegang reeksen en oefeningen uitleggen)
    • User management

@winniederidder winniederidder marked this pull request as ready for review August 13, 2020 06:42
@winniederidder
Copy link
Contributor Author

Guilabel has no style (but this part is in @LucianosLionakis his PR
Inter page links also depend on not yet migrated pages, which will be fixed when they are migrated.

Copy link
Member

@rien rien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dodona has changed quite a lot apparently since these docs were written. Some stuff will need to be rewritten or removed.

@winniederidder winniederidder requested a review from rien August 14, 2020 08:24
@winniederidder winniederidder changed the title Teacher docs/user management Teacher docs Aug 17, 2020
Copy link
Member

@rien rien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also group the articles in the for-teachers guide together (like #72).

The dutch page of course management doesn't seem to be rendering here. Can you check what the problem is?

@winniederidder winniederidder requested a review from rien August 27, 2020 12:26
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move these pages under getting started as with the student docs
  • Add a TOC to these pages since the are not a guide and just a collection of topics
  • significantly reduce the number of links

@winniederidder
Copy link
Contributor Author

winniederidder commented Aug 31, 2020

Not sure if moving can be done as Lucianos his PR isn't merged yet.
I will also apply these comments on the other pages, but they are also up for review.

@winniederidder
Copy link
Contributor Author

vuejs/vuepress#2562

Issue concerning scrolling, most noticeable when using links between pages.

@bmesuere bmesuere force-pushed the teacher-docs/user-management branch from bd57f8e to 5f7e6e3 Compare September 5, 2020 16:53
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo in separate pull request:

  • split out review to a separate page
  • nest the pages to improve sidebar structure

@bmesuere bmesuere merged commit 9fb37fa into main Sep 5, 2020
@bmesuere bmesuere deleted the teacher-docs/user-management branch September 5, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants