Make the result of fragment-matcher deterministic
#7367
Assignees
Labels
Comments
|
Hi @filipcro, This could definitely be a new optional configuration option to the Let me know when your PR is ready and I'll review it. |
tgandrews
added a commit
to tgandrews/graphql-code-generator
that referenced
this issue
Dec 8, 2024
This exposes a new plugin option `deterministic` that when enabled will ensure that the fragment matcher will always return the same result for the same schema, no matter the order it is in the schema. It does this by sorting the results so that they are always in the same order. The default is `false` to maintain backwards compatibility. This fixes dotansimha#7367
11 tasks
|
@charlypoly This has been done in #10214 are you still up for reviewing it 🙏 |
|
Hello @tgandrews , I can take a look soon 🙂 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Hi. We have a repo where multiple developers are working on the same project. In the same repo result of
fragment-matcheris saved to.jsonand committed. The thing that happens is that every time somebody generates this file, values in possible type arrays are sorted differently. I.e."ConfirmEmailResponse": [ "SuccessPayload", - "EmailDoesNotExists", - "InvalidToken" + "InvalidToken", + "EmailDoesNotExists" ],Describe the solution you'd like
Have an option to sort values in possible type arrays alphabetical.
This shouldn't be hard to do. We just need to add
.sort()in this file. I can create MR if you approve of this, but I need to know will this be optional feature, and how would opt in look like in config file.The text was updated successfully, but these errors were encountered: