-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Signed-out callback path coverage #34385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UPDATE (12/18): I'm waiting to hear back from @halter73 if ... https://learn.microsoft.com/en-us/entra/identity-platform/quickstart-web-app-dotnet-core-sign-in ... is a suitable MSAL/MS Identity Web/Entra article to cross-link at the top of the RP+OIDC article. Otherwise, I've made the relevant updates to 🔪 most of the Entra guidance from the two OIDC articles. However, I left a bit in a NOTE in those articles just in case someone uses the OIDC bits with Entra. I'd like to avoid unnecessary doc issues. @damienbod ... Looks like your article wasn't edited by anyone before it was published. I only had a few minutes for a quick pass, but I fixed a few nits and bits here and there. It's all just minor grammar and style manual stuff, along with our 1,000 repo-specific (undocumented) conventions. Yikes! I see more Entra stuff in the Blazor+OIDC article to address. Another commit is coming! 🏃♂️ |
I found another sample link to include for External ID at ... ... so we'll see if that along with ... https://learn.microsoft.com/en-us/entra/external-id/customers/sample-web-app-dotnet-sign-in ... are the ones Stephen is cool with. That's it for today. I'll make a final pass on Thursday morning. |
@halter73 ...
Hold on ... I think I found it .... THIS ONE? ... I'll place that one, and you can let me know if that's the wrong one. |
That's it! |
Co-authored-by: Stephen Halter <[email protected]>
aspnetcore/security/authentication/configure-oidc-web-authentication.md
Outdated
Show resolved
Hide resolved
aspnetcore/security/authentication/configure-oidc-web-authentication.md
Outdated
Show resolved
Hide resolved
@halter73 ... I performed a few more passes to mop up the last few changes. I'll merge now. I'm clearing out as many work items and closing as many PRs as I can before taking off for the 🎄 holidays. If you have further updates, please open a new issue from the bottom of the article, and I'll either try to get them in quickly now or take care of them in January. Happy Holidays! ⛄ |
This reverts commit f778f86.
This comment was marked as spam.
This comment was marked as spam.
@meslubi2021 ... STOP COMMENTING! You've been reported to GitHub! |
Fixes #34378
Fixes #34395
cc: @damienbod if you want to take a look and provide feedback.
Notes
Internal previews