Skip to content

Commit 62b5dfb

Browse files
committed
Replace AllocRatio ctor creation to the static field, like BaselineRatioColumn.RatioMean
1 parent 730ae19 commit 62b5dfb

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

src/BenchmarkDotNet/Columns/BaselineAllocationRatioColumn.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ public class BaselineAllocationRatioColumn : BaselineCustomColumn
1414
public override string Id => nameof(BaselineAllocationRatioColumn);
1515
public override string ColumnName => "Alloc Ratio";
1616

17+
public static readonly IColumn RatioMean = new BaselineAllocationRatioColumn();
18+
19+
private BaselineAllocationRatioColumn() { }
20+
1721
public override string GetValue(Summary summary, BenchmarkCase benchmarkCase, Statistics baseline, IReadOnlyDictionary<string, Metric> baselineMetrics,
1822
Statistics current, IReadOnlyDictionary<string, Metric> currentMetrics, bool isBaseline)
1923
{

src/BenchmarkDotNet/Columns/DefaultColumnProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public IEnumerable<IColumn> GetColumns(Summary summary)
6666

6767
if (HasMemoryDiagnoser(summary))
6868
{
69-
yield return new BaselineAllocationRatioColumn();
69+
yield return BaselineAllocationRatioColumn.RatioMean;
7070
}
7171
}
7272
}

src/BenchmarkDotNet/Helpers/ColumnEnumHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public static IColumnHidingRule[] ExtractRules(Column[] columns) =>
2727
Column.Median => ById(StatisticColumn.Median),
2828
Column.BaselineRatio => ById(BaselineRatioColumn.RatioMean),
2929
Column.BaselineRatioSD => ById(BaselineRatioColumn.RatioStdDev),
30-
Column.BaselineAllocRatio => ByTypeAndName(typeof(BaselineAllocationRatioColumn), "Alloc Ratio"),
30+
Column.BaselineAllocRatio => ById(BaselineAllocationRatioColumn.RatioMean),
3131
_ or Column.None => null
3232
};
3333

tests/BenchmarkDotNet.Tests/ColumnEnumHelperTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public void ColumnsHiddenCorrectly()
2222
VerifyHiding(Column.Median, StatisticColumn.Median);
2323
VerifyHiding(Column.BaselineRatio, BaselineRatioColumn.RatioMean);
2424
VerifyHiding(Column.BaselineRatioSD, BaselineRatioColumn.RatioStdDev);
25-
VerifyHiding(Column.BaselineAllocRatio, new BaselineAllocationRatioColumn());
25+
VerifyHiding(Column.BaselineAllocRatio, BaselineAllocationRatioColumn.RatioMean);
2626
}
2727

2828
[Theory]

0 commit comments

Comments
 (0)