Skip to content

Add support for <UseArtifactsOutput>true</UseArtifactsOutput> #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nojaf opened this issue Nov 16, 2023 · 4 comments · Fixed by #2393
Closed

Add support for <UseArtifactsOutput>true</UseArtifactsOutput> #2466

nojaf opened this issue Nov 16, 2023 · 4 comments · Fixed by #2393
Assignees
Milestone

Comments

@nojaf
Copy link

nojaf commented Nov 16, 2023

Hello,

I've recently updated to the dotnet 8 SDK and I've enabled true.

When running my benchmark dotnet artifacts/bin/Fantomas.Benchmarks/release/Fantomas.Benchmarks.dll:

dotnet artifacts/bin/Fantomas.Benchmarks/release/Fantomas.Benchmarks.dll                                                                                                                                                                                                                  ❮  7s 682ms      
// Validating benchmarks:
// ***** BenchmarkRunner: Start   *****
// ***** Found 1 benchmark(s) in total *****
// ***** Building 1 exe(s) in Parallel: Start   *****
// start dotnet  restore /p:UseSharedCompilation=false /p:BuildInParallel=false /m:1 /p:Deterministic=true /p:Optimize=true in C:\Users\nojaf\Projects\fantomas\artifacts\bin\Fantomas.Benchmarks\release\94c3c585-184c-4f7d-a1d7-6c975b7cc114
// command took 0.95 sec and exited with 0
// start dotnet  build -c Release --no-restore /p:UseSharedCompilation=false /p:BuildInParallel=false /m:1 /p:Deterministic=true /p:Optimize=true in C:\Users\nojaf\Projects\fantomas\artifacts\bin\Fantomas.Benchmarks\release\94c3c585-184c-4f7d-a1d7-6c975b7cc114
// command took 1.94 sec and exited with 0
// ***** Done, took 00:00:02 (2.94 sec)   *****
// Found 1 benchmarks:
//   CodePrinterTest.Format: DefaultJob

Setup power plan (GUID: 8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c FriendlyName: High performance)
// **************************
// Benchmark: CodePrinterTest.Format: DefaultJob
// *** Execute ***
// Launch: 1 / 1
Did not find C:\Users\nojaf\Projects\fantomas\artifacts\bin\Fantomas.Benchmarks\release\94c3c585-184c-4f7d-a1d7-6c975b7cc114\bin\Release\net8.0\94c3c585-184c-4f7d-a1d7-6c975b7cc114.dll, but the folder contained:
94c3c585-184c-4f7d-a1d7-6c975b7cc114.dll.config
Executable C:\Users\nojaf\Projects\fantomas\artifacts\bin\Fantomas.Benchmarks\release\94c3c585-184c-4f7d-a1d7-6c975b7cc114\bin\Release\net8.0\94c3c585-184c-4f7d-a1d7-6c975b7cc114.dll not found
ExitCode != 0 and no results reported
No Workload Results were obtained from the run.

// ** Remained 0 (0.0%) benchmark(s) to run. Estimated finish 2023-11-16 16:09 (0h 0m from now) **
Successfully reverted power plan (GUID: 8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c FriendlyName: High performance)
// ***** BenchmarkRunner: Finish  *****

It was unable to find the right dll due to the new layout.
Am I missing some configuration? Or is this a gap and can we add support for this?

craigktreasure added a commit to craigktreasure/Treasure.Utils that referenced this issue Nov 17, 2023
This change adds support for .NET 8. Unlike similar PRs in my other repos, it does not enable artifacts support yet due to an issue with [benchmarkdotnet](dotnet/BenchmarkDotNet#2466).
craigktreasure added a commit to craigktreasure/Treasure.Utils that referenced this issue Nov 18, 2023
This change adds support for .NET 8. Unlike similar PRs in my other repos, it does not enable artifacts support yet due to an issue with [benchmarkdotnet](dotnet/BenchmarkDotNet#2466).
craigktreasure added a commit to craigktreasure/Treasure.Utils that referenced this issue Nov 18, 2023
This change adds support for .NET 8. Unlike similar PRs in my other repos, it does not enable artifacts support yet due to an issue with [benchmarkdotnet](dotnet/BenchmarkDotNet#2466).
@malstraem
Copy link

Any updates? 👀

@timcassell
Copy link
Collaborator

It looks like this will be fixed by #2393.

@timcassell timcassell linked a pull request Jan 20, 2024 that will close this issue
@timcassell timcassell self-assigned this Jan 20, 2024
@AndreyAkinshin AndreyAkinshin added this to the v0.14.0 milestone Jan 22, 2024
@viceice
Copy link

viceice commented Feb 7, 2024

Is there a workaround for v0.13.x?

@timcassell
Copy link
Collaborator

timcassell commented Feb 7, 2024

@viceice The only workaround is to not use <UseArtifactsOutput> property.

You could also try the latest nightly build. https://benchmarkdotnet.org/articles/guides/nuget.html#nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants