API Version Support is Incompatible with OData for Web API Library 6.0

[commonsensesoftware]

Changes in the OData library 6.0 for Web API introduces changes that are incompatible with the OData API versioning support. OData API versioning should also support 6.0. Various incompatibility issues arise as reported by issue #35.

[joaopbnogueira]

Hi,

Is this issue being addressed by anyone?

I'm working on a fix, but it won't be backwards-compatible with the current version.

The solution requires a change of interface in the MapVersionedODataRoutes methods to something like:

public static IReadOnlyList<ODataRoute> MapVersionedODataRoutes(this HttpConfiguration configuration, string routeName, string routePrefix, Action<IContainerBuilder> configureAction, IEnumerable<IEdmModel> models)

Thanks

[commonsensesoftware]

Unfortunately, it's just been me and I've been tied up with other priorities; primarily my day job. I'm a strong advocate and consumer of OData, so being able to move past 5.9.1 to 6.0+ is something I definitely want to see happen.

From my cursory examination, I know that support for 6.0+ won't be backward compatible. There are significant breaking changes in the OData library. It's unfortunate that the changes are breaking, but the from what I've seen, I'm pleased with the changes they've made; I think it's in the right direction.

I believe you're right, most of the changes are in the related MapVersionedODataRoutes. Since DI has now been introduced with first-class support, I'm not even sure these methods are required anymore. They were needed to change the behaviors of how routing was setup, including behaviors like conventions, casing, etc. I believe that most or all of these aspects can now be changed via the DI support.

I'll see if I can dedicate some time this week. If you have anything to show or share, I'm more than happy to take a look.

[joaopbnogueira]

Sure, I already have a POC working on .Net 4.5.2. and will push the code to my fork so that you can have a look / comment. João Nogueira 2017-01-05 18:04 GMT+00:00 Chris Martinez <[email protected]>:

…

Unfortunately, it's just been me and I've been tied up with other priorities; primarily my day job. I'm a strong advocate and consumer of OData, so being able to move past 5.9.1 to 6.0+ is something I definitely want to see happen. From my cursory examination, I know that support for 6.0+ won't be backward compatible. There are significant breaking changes in the OData library. It's unfortunate that the changes are breaking, but the from what I've seen, I'm pleased with the changes they've made; I think it's in the right direction. I believe you're right, most of the changes are in the related *MapVersionedODataRoutes*. Since DI has now been introduced with first-class support, I'm not even sure these methods are required anymore. They were needed to change the behaviors of how routing was setup, including behaviors like conventions, casing, etc. I believe that most or all of these aspects can now be changed via the DI support. I'll see if I can dedicate some time this week. If you have anything to show or share, I'm more than happy to take a look. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABj7JiYPPPfr0By2wTet_JftIpln9bO7ks5rPTDDgaJpZM4KaGkt> .

[joaopbnogueira]

Have a look at my latest commit here

• With the exception of VersionedMetadataRoutingConventionTest.cs all tests pass on Microsoft.AspNet.OData.Versioning.Tests
• I'm not sure how to reference types "MetadataPathSegment/EntitySetPathSegment", or if the tests still make sense.