Skip to content

Always ref request body and response schemas and fix nested types #56513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2024
Merged

Always ref request body and response schemas and fix nested types #56513

merged 2 commits into from
Jul 2, 2024

Conversation

captainsafia
Copy link
Member

  • Always capture top-level request body and response schemas by ref to react to feedback in OpenAPI schema references feedback #56318
  • Fix handling of nested types in properties
  • Fix handling of nullable primitive in GetSchemaReferenceId
  • Update tests to resolve schemas that are now indicated by reference instead of inlined

@captainsafia captainsafia requested a review from a team as a code owner June 28, 2024 17:07
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jun 28, 2024
@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Jun 28, 2024
@captainsafia captainsafia requested a review from mikekistler July 1, 2024 16:41
@captainsafia
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia captainsafia enabled auto-merge (squash) July 1, 2024 22:48
@captainsafia captainsafia merged commit 13f3713 into main Jul 2, 2024
26 checks passed
@captainsafia captainsafia deleted the safia/openapi-fixes branch July 2, 2024 08:07
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@mikekistler mikekistler Awaiting requested review from mikekistler

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Projects
None yet
Milestone
9.0-preview7
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @BrennanConroy