Skip to content

Fix comment typos in build props #56544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

gitslav
Copy link
Contributor

@gitslav gitslav commented Jul 1, 2024

Fix comment typos in build props

Description

Fixes typos in eng/Build.props and eng/Signing.props

@gitslav gitslav requested review from wtgodbe and a team as code owners July 1, 2024 11:55
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 1, 2024
@gitslav
Copy link
Contributor Author

gitslav commented Jul 1, 2024

@dotnet-policy-service agree

Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these.

@gitslav
Copy link
Contributor Author

gitslav commented Jul 2, 2024

@mkArtakMSFT @wtgodbe there was a test failing but it is now quarantined in #56562.

@mkArtakMSFT
Copy link
Member

@gitslav can you please rebase to main? Thanks!

@gitslav gitslav force-pushed the fix-comment-typos-in-build-props branch from 5d48278 to f38fda5 Compare July 2, 2024 21:13
@wtgodbe wtgodbe merged commit 091da45 into dotnet:main Jul 2, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants