Skip to content

Redesign [debug] directive for end user opt-in #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonsequitur opened this issue Feb 2, 2022 · 5 comments
Open

Redesign [debug] directive for end user opt-in #1607

jonsequitur opened this issue Feb 2, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@jonsequitur
Copy link
Contributor

The [debug] directive allowed for a consistent way to attach a debugger and stop on a breakpoint in an application's startup code. We weren't satisfied with the security of the design. Ideally, this functionality should be opt-in by the end user rather than determined by the application developer.

One proposal is to have the debug check verify the presence of a different user-installed tool before pausing to attach the debugger.

@drewburlingame
Copy link

I had implemented a similar directive in CommandDotNet but found that I often wanted the debugger to run before the app was configured so I could validate the configuration, especially when running middleware. So I created this static method that can be called before configuring the application. It doesn't address the security issue but I've found it more useful.

@skrysmanski
Copy link

@jonsequitur

We weren't satisfied with the security of the design.

Could elaborate a little bit on what you mean by this exactly? :)

@jonsequitur
Copy link
Contributor Author

As implemented, the [debug] directive presented a way to cause a tool using it to hang indefinitely while it waits for user input.

@KalleOlaviNiemitalo
Copy link

Should the documentation of [debug] be commented out until the feature is restored?

@jonsequitur
Copy link
Contributor Author

jonsequitur commented Jun 17, 2022

Apologies. The docs in this repo are outdated and need to be removed. The official documentation is here and doesn't mention [debug].

bantolov added a commit to Rhetos/Rhetos that referenced this issue Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants