Skip to content

Replace ValidateSymbolResult delegate with Action<T> #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1946
Closed
Tracked by #1891

Replace ValidateSymbolResult delegate with Action<T> #1944

jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1946
Assignees
@adamsitnik
Labels
Area-API
Milestone
2.0 GA

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022 •
edited
Loading 

    // See above for guidelines on naming delegates.
    // And that you shouldn't define new delegates unless you need to. (just be Action<SymbolResult>)
    public delegate void ValidateSymbolResult<in T>(T symbolResult) where T : SymbolResult;
@jonsequitur jonsequitur mentioned this issue Nov 2, 2022
Open
56 tasks
@jonsequitur jonsequitur changed the title Replace ValidateSymbolResult with Action<T> Replace ValidateSymbolResult delegate with Action<T> Nov 2, 2022
@adamsitnik adamsitnik self-assigned this Nov 4, 2022
@adamsitnik adamsitnik mentioned this issue Nov 4, 2022
Merged
adamsitnik added a commit to adamsitnik/command-line-api that referenced this issue Nov 4, 2022
@adamsitnik
Replace ValidateSymbolResult delegate with Action<T>, fixes dotnet#1944
bc31468
@jonsequitur jonsequitur added this to the 2.0 GA milestone Nov 9, 2022
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsitnik adamsitnik

Labels
Area-API
Projects
None yet
Milestone
2.0 GA
Development

Successfully merging a pull request may close this issue.

Remove CompletionDelegate, CompletionSourceList and DirectiveCollection adamsitnik/command-line-api
2 participants
@jonsequitur @adamsitnik