Skip to content

AddValidator methods should be fluent #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1891
adamsitnik opened this issue Nov 14, 2022 · 0 comments · Fixed by #1966
Closed
Tracked by #1891

AddValidator methods should be fluent #1965

adamsitnik opened this issue Nov 14, 2022 · 0 comments · Fixed by #1966
Assignees
@adamsitnik

Comments

@adamsitnik
Copy link
Member

While working on #1964 I've realized that we allow the users to add completions in fluent way, but at the same time we don't do it for the validators.

Proposed change:

- void AddValidator(Action<ArgumentResult> validate)
+ Argument<T> AddValidator(Action<ArgumentResult> validate)

- void AddValidator(Action<OptionResult> validate)
+ Option<T> AddValidator(Action<OptionResult> validate)

cc @jonsequitur @jozkee
@adamsitnik adamsitnik mentioned this issue Nov 14, 2022
Open
56 tasks
@adamsitnik adamsitnik self-assigned this Nov 14, 2022
adamsitnik added a commit to adamsitnik/command-line-api that referenced this issue Nov 14, 2022
@adamsitnik
make AddValidator fluent, fixes dotnet#1965
8884c10
@adamsitnik adamsitnik mentioned this issue Nov 14, 2022
Merged
adamsitnik added a commit that referenced this issue Nov 14, 2022
@adamsitnik
make AddValidator fluent, fixes #1965 (#1966)
9266d5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsitnik adamsitnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make AddValidator fluent adamsitnik/command-line-api
1 participant
@adamsitnik