Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Dummy TailCallCopyArgsThunk for altjit #19914

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

CarolEidt
Copy link

Make it easier to track down tail call stress failures.

@CarolEidt
Copy link
Author

@dotnet/jit-contrib PTAL
There may be a better way to do this, but adding this made it much easier for me to track down a failure in the GitHub_18362 tailcallstress test. This is the second one of these I've had to track down, and not likely to be the last, since I'm making non-trivial modifications to the ABI handling code.

@@ -8316,7 +8316,12 @@ GenTree* Compiler::fgMorphCall(GenTreeCall* call)
: CORINFO_TAILCALL_NORMAL);
if (pfnCopyArgs == nullptr)
{
#ifdef ALT_JIT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want #ifdef ALT_JIT; I think instead we want to use info.compMatchedVM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll make the change. Do you think that this should be DEBUG-only?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be DEBUG only; we use compMatchedVM in non-DEBUG contexts today.

@CarolEidt
Copy link
Author

@dotnet-bot test Windows_NT x64 Formatting

@CarolEidt
Copy link
Author

@BruceForstall - I've made the change you suggested.

@CarolEidt
Copy link
Author

@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test

1 similar comment
@CarolEidt
Copy link
Author

@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test

@CarolEidt
Copy link
Author

Windows_NT arm64 Cross Checked Innerloop Build and Test

@CarolEidt
Copy link
Author

@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test

@CarolEidt CarolEidt merged commit 9ff41e7 into dotnet:master Oct 15, 2018
@CarolEidt CarolEidt deleted the AltJitTailCall branch November 14, 2019 01:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants