-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Dummy TailCallCopyArgsThunk for altjit #19914
Conversation
@dotnet/jit-contrib PTAL |
src/jit/morph.cpp
Outdated
@@ -8316,7 +8316,12 @@ GenTree* Compiler::fgMorphCall(GenTreeCall* call) | |||
: CORINFO_TAILCALL_NORMAL); | |||
if (pfnCopyArgs == nullptr) | |||
{ | |||
#ifdef ALT_JIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want #ifdef ALT_JIT
; I think instead we want to use info.compMatchedVM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I'll make the change. Do you think that this should be DEBUG-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it needs to be DEBUG only; we use compMatchedVM
in non-DEBUG contexts today.
@dotnet-bot test Windows_NT x64 Formatting |
@BruceForstall - I've made the change you suggested. |
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test |
1 similar comment
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test |
Windows_NT arm64 Cross Checked Innerloop Build and Test |
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test |
Make it easier to track down tail call stress failures.