Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Optimize some SSE2 intrinsic importation and re-enable tests #20173

Merged
merged 2 commits into from
Oct 3, 2018

Conversation

fiigii
Copy link

@fiigii fiigii commented Sep 28, 2018

This PR

  1. re-enables the hardware intrinsic tests that were disabled in Fix inconsistent Intel hardware intrinsic APIs #19949 and moves to template-based.
  2. optimize some SSE2 intrinsic importation by removing unnecessary HW_Flag_BaseTypeFromFirstArg, which avoid calling into the expensive VM functions.

@fiigii
Copy link
Author

fiigii commented Sep 28, 2018

@CarolEidt @tannergooding PTAL

@fiigii
Copy link
Author

fiigii commented Sep 28, 2018

@dotnet-bot test Windows_NT x64 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic

@dotnet-bot test Windows_NT x86 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x86 Checked jitnox86hwintrinsic

@dotnet-bot test Ubuntu x64 Checked jitincompletehwintrinsic
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Ubuntu x64 Checked jitnox86hwintrinsic

// See the LICENSE file in the project root for more information.
//

using System;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could just move this to be templated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will be changed again after exposing 64-bit intrinsic in nested classes. Let’s move them later.

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like to see PopCnt moved to a templated test, if possible.

@fiigii
Copy link
Author

fiigii commented Oct 1, 2018

Can we merge this?

@tannergooding
Copy link
Member

It would be nice if @CarolEidt could give this a cursory glance as well.

@fiigii
Copy link
Author

fiigii commented Oct 1, 2018

Thanks, I will move all the scalar intrinsic tests to the template after #20146 gets done.

@fiigii
Copy link
Author

fiigii commented Oct 3, 2018

@CarolEidt ping?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants