-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Optimize some SSE2 intrinsic importation and re-enable tests #20173
Conversation
@CarolEidt @tannergooding PTAL |
@dotnet-bot test Windows_NT x64 Checked jitincompletehwintrinsic @dotnet-bot test Windows_NT x86 Checked jitincompletehwintrinsic @dotnet-bot test Ubuntu x64 Checked jitincompletehwintrinsic |
// See the LICENSE file in the project root for more information. | ||
// | ||
|
||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could just move this to be templated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will be changed again after exposing 64-bit intrinsic in nested classes. Let’s move them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like to see PopCnt moved to a templated test, if possible.
Can we merge this? |
It would be nice if @CarolEidt could give this a cursory glance as well. |
Thanks, I will move all the scalar intrinsic tests to the template after #20146 gets done. |
@CarolEidt ping? |
This PR
HW_Flag_BaseTypeFromFirstArg
, which avoid calling into the expensive VM functions.