This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add string.GetHashCode(ROS<char>) and related APIs #20422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Oct 15, 2018
jkotas
reviewed
Oct 15, 2018
src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 16, 2018
|
Thanks @jkotas and @stephentoub! Getting to the feedback took a backseat due to some other higher-priority work, but I plan on getting back to this by end of week. |
GrabYourPitchforks
force-pushed
the
span_gethashcode
branch
from
9aa86c5 to
934dc0d
Compare
tarekgh
approved these changes
Nov 7, 2018
|
OSX failure is due to full disk, unrelated to this PR. |
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test Edit: Or not. That's cool, too, bot. :) |
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corefx
that referenced
this pull request
Nov 8, 2018
) Signed-off-by: dotnet-bot <[email protected]>
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corert
that referenced
this pull request
Nov 8, 2018
) Signed-off-by: dotnet-bot <[email protected]>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Nov 8, 2018
) Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Nov 8, 2018
) Signed-off-by: dotnet-bot <[email protected]>
|
Will this get into full framework as well, or just .net core? Or is it net standard? |
|
Just .net core
It will make its way to net standard, but that net standard won't be supported on full framework: https://blogs.msdn.microsoft.com/dotnet/2018/11/05/announcing-net-standard-2-1/ |
A-And
pushed a commit
to A-And/coreclr
that referenced
this pull request
Nov 20, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/31302.
Per https://github.com/dotnet/corefx/issues/31302#issuecomment-407542677, the newly added API on
CompareInfois non-virtual. Unit tests will be coming through a different PR in corefx. I'll link to that PR when it's ready.I'll also rerun some of the perf benchmarks to ensure we haven't regressed culture-aware hash code calculation performance.